[WebProfilerBundle] Fixed profiler seach/homepage with empty token #10820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tucksaun
commented
Apr 30, 2014
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #10806 |
| License | MIT |
| Doc PR | none |
|
Thank you @tucksaun. |
fabpot
added a commit
that referenced
this pull request
Apr 30, 2014
…ty token (tucksaun) This PR was merged into the 2.3 branch. Discussion ---------- [WebProfilerBundle] Fixed profiler seach/homepage with empty token | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #10806 | License | MIT | Doc PR | none Commits ------- 16dd0e5 [WebProfilerBundle] added test case for #10773 5b91e70 [WebProfilerBundle] fixed profiler homepage, fixed #10806 7b425d2 [WebProfilerBundle] Added test case for #10806
|
Shouldn't be merged this PR in 2.4 and master as well? |
|
@perajovic This is done from time to time, so no need to worry about, it will be done for sure. |
|
@perajovic 2.3 is regularly merge in 2.4 and 2.4 in master |
|
Yes, I know. But a few moments ago I checked a master's log and it wasn't there. Some previous commit was already merged in all current branches 2.3/2.4/master, so I thought that something is wrong... Cheers! |
|
@perajovic 2.4 was merged into master 5 hours ago. this PR has only been merged 2 hours ago |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.