[2.3] Fix phpunit test suite on travis #2 #10826
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Forget what I said, This implementation does not seem to work, anyway |
|
Reopening as waiting for the PHPUnit release was necessary for |
|
arf, PHP 5.3.3 does not have openssl on Travis 😞 |
|
@romainneutron an alternative could be to download |
|
yep that's the only solution, I'm gonna give a try to this proposition |
fabpot
added a commit
that referenced
this pull request
Apr 30, 2014
This PR was merged into the 2.3 branch. Discussion ---------- [2.3] Fix phpunit test suite on travis #2 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #10821 | License | MIT This is a second approach to solve #10821. Something is weird: `Symfony\Component\Form\Tests\Extension\Core\EventListener\TrimListenerTest` passes when using PHPUnit as phar and fails when using a composer global install Commits ------- 32e5f67 [DependencyInjection] Fix travis unit tests c7befd5 Update PHPUnit before run
|
@romainneutron this is actually not needed anymore (for the Travis update part), as Travis updated PHPUnit to 4.0.19 |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a second approach to solve #10821.
Something is weird:
Symfony\Component\Form\Tests\Extension\Core\EventListener\TrimListenerTestpasses when using PHPUnit as phar and fails when using a composer global install