Skip to content

[HttpKernel] added an analyze of environment parameters for built-in server #10914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

mauchede
Copy link

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
Fixed tickets #10208
License MIT
Doc PR -

With the built-in server, it is not possible to use the external parameters: environment variables are only in $_ENV.

@fabpot
Copy link
Member

fabpot commented Jul 25, 2014

This change should be done in the built-in web server directly, not in the Kernel class.

@mauchede
Copy link
Author

mauchede commented Aug 8, 2014

The changes have been moved into the files router_dev.php and router_prod.php.

@stof
Copy link
Member

stof commented Aug 8, 2014

btw, this should probably be reported to PHP as it looks like a bug in the builtin webserver

@fabpot
Copy link
Member

fabpot commented Aug 8, 2014

👍

@stof
Copy link
Member

stof commented Aug 8, 2014

👍 but please report the issue to PHP as well.

@fabpot
Copy link
Member

fabpot commented Aug 8, 2014

Thank you @mauchede.

fabpot added a commit that referenced this pull request Aug 8, 2014
…r built-in server (mauchede)

This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #10914).

Discussion
----------

[HttpKernel] added an analyze of environment parameters for built-in server

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | #10208
| License       | MIT
| Doc PR        | -

With the built-in server, it is not possible to use the external parameters: environment variables are only in `$_ENV`.

Commits
-------

696b978 [HttpKernel] added an analyze of environment parameters for built-in server.
@fabpot fabpot closed this Aug 8, 2014
@mauchede
Copy link
Author

mauchede commented Aug 8, 2014

@fabpot : You're welcome!

@Stop : The issue has been created.

@mauchede mauchede deleted the t10208 branch September 5, 2014 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants