[Validator] Added option for specifying the size format for the File validator #10917
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh! And I'll make a doc PR asap |
|
Not sure I like to add yet another option for this. Why not choose one format (whatever it is) and document that we only support this one. That would be much better I think in the long run. |
|
Actually, there is a default format, which you may override. Both are alright I think. In any case, we don't want to change this at a later date. |
| @@ -25,6 +25,7 @@ class File extends Constraint | |||
| { | |||
| public $maxSize = null; | |||
| public $mimeTypes = array(); | |||
| public $sizeFormat = 'binary'; | |||
There was a problem hiding this comment.
You can use the constant FileValidator::SIZE_FORMAT_BINARY
|
Should |
This lets someone choose between binary (multiples of 1024) and decimal (multiple of 1000) formats for specifying the size
|
Took @jeremy-derusse's feedback into account. |
fabpot
added a commit
that referenced
this pull request
May 22, 2014
This PR was merged into the 2.5-dev branch. Discussion ---------- Made use of "kB" vs. "KiB" consistent | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Continuation of #10661. This PR makes the usage of "kB" and "KiB" consistent across the project. The notations equal the internationally recognized ones: Short form | Long form | Value in Bytes --- | --- | --- B | bytes | 1 kB | kilobytes | 1000 KiB | kibibytes | 1024 MB | megabytes | 1000000 MiB | mebibytes | 1048576 GB | gigabytes | 1000000000 GiB | gibibytes | 1073741824 The reason for differentiating between the two is that several users got confused with the current mix (see #10648, #10917, #10661). FileValidator, UploadedFile and the ProgressBar helper were changed accordingly. Follow-up feature request: #10962 Commits ------- e4c6da5 [Validator] Improved to-string conversion of the file size/size limit bbe1045 [Validator][Console][HttpFoundation] Use "KiB" everywhere (instead of "kB")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets someone choose between binary (multiples of 1024) and decimal (multiple of 1000) formats for specifying the size.
Example:
By default, the size format is in binary.