[Process] Add support for streams as input #10934
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| array('file', '/dev/tty', 'w'), | ||
| array('file', '/dev/tty', 'w'), | ||
| ); | ||
| } elseif ($this->ptyMode && Process::isPtySupported()) { |
There was a problem hiding this comment.
just if as the previous if returns
|
Updated, addressed @stof comments |
| * @param bool $blocking Whether to use blocking calls or not. | ||
| * @param bool $close Whether to close pipes if they've reached EOF. | ||
| * | ||
| * @return string An array of read data indexed by their fd. |
There was a problem hiding this comment.
Is string correct? the description tells otherwise.
There was a problem hiding this comment.
@romainneutron Can you fix this before I merge?
|
PR has been updated, comments have been addressed |
|
👍 |
|
Love that 👍 |
|
👍 I think the PipesInterface should be tagged as |
|
@romainneutron Can you tag all internal classes to make it clear that BC rules do no apply to these classes? |
|
Classes have been tagged, PR has been rebased |
|
Thanks @romainneutron. |
|
@romainneutron this should be documented (you omitted the "Doc PR" line in your summary btw) |
|
@stof I've opened an issue for this, see symfony/symfony-docs#3955 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Process::setStdinnow accepts a stream as input.I've also split windows and unix pipes management.