[Debug] cleanup interfaces before 2.5-final #10941
Conversation
|
Call for review: |
| $trace = array(); | ||
| } | ||
|
|
||
| $this->setTrace($trace); |
There was a problem hiding this comment.
why duplicating all this logic here, while it is already done by the parent class ?
There was a problem hiding this comment.
Right, I'll add an argument to the constructor instead
There was a problem hiding this comment.
is there a difference in the logic in both cases ? I haven't checked the code locally to be able to compare both files easily
There was a problem hiding this comment.
OK, saw it. It is the usage of params in the trace
|
Any comment here? Otherwise @fabpot this is 👍 for merge in 2.5 on my side |
| * Sets a user exception handler. | ||
| * | ||
| * @param callable $handler An handler that will be called on Exception | ||
| */ |
There was a problem hiding this comment.
missing documentation for @return
|
Thank you @nicolas-grekas. |
…rekas) This PR was merged into the 2.4-dev branch. Discussion ---------- [Debug] cleanup interfaces before 2.5-final | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | none This PR is targeted at cleaning up interfaces before 2.5 final: - ExceptionHandlerInterface has never been released in a stable Symfony, lets drop it, not deprecate it, - generalize a little bit how fatal errors are handled and make them take the same path as uncaught exceptions, - enhance handling of out of memory situations. Commits ------- e3255bf [Debug] better ouf of memory error handling dfa8ff8 [Debug] cleanup interfaces before 2.5-final
This PR is targeted at cleaning up interfaces before 2.5 final: