[Validator] Fix propertyPath with nested collections in the LegacyExecutionContext #11074
Conversation
| 'name' => new ConstraintA(), | ||
| 'books' => new All(array('constraints' => array( | ||
| new ConstraintA() | ||
| ))) |
There was a problem hiding this comment.
is this indentation correct @jakzal ?
|
tests fail @jakzal, it seems your patch breaks the build |
|
@cordoval no, this patch doesn't break the build. Look at what's broken. |
|
oh cool you fixed it 👍 |
|
👍 |
|
Please check this ticket: #11072 - this patch fixes the older code, but still keeps the newer one producing unexpected (at least for me) results. |
|
@webmozart could you have a look at this PR please? I'm no longer sure about cloning, or if it's in the right place. I'm confident about the property path fix and could prepare a separate PR just for that if needed. |
|
@jakzal Please submit the property path bugfix separately so that we can merge it without waiting for @webmozart's feedback on the way to fix the contextual validator |
|
@jakzal can you rebase this one ? It conflicts with the current 2.5 branch |
… LegacyExecutionContext.
|
@stof done I'm not sure if clone was done at right place. Might be it should actually be done inside the |
|
Replaced by #11412. |
Some tests are failing for other reasons.