Fixed undefined ImageValidator::$suffices property when uploading an image during functional tests #11111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -29,7 +29,7 @@ class FileValidator extends ConstraintValidator | |||
|
|
|||
| const MB_BYTES = 1000000; | |||
|
|
|||
| private static $suffices = array( | |||
| protected static $suffices = array( | |||
There was a problem hiding this comment.
static::$suffices[$coef] should be changed to self::$suffices[$coef] instead
There was a problem hiding this comment.
I agree with @Tobion. there is no point changing the visibility. Fixing the code reading it is better
|
I changed the fix so now $suffices will be accessed via |
|
👍 |
1 similar comment
|
👍 |
|
Thank you @OwlyCode. |
fabpot
added a commit
that referenced
this pull request
Jun 12, 2014
…loading an image during functional tests (OwlyCode) This PR was squashed before being merged into the 2.5 branch (closes #11111). Discussion ---------- Fixed undefined ImageValidator::$suffices property when uploading an image during functional tests | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11110 | License | MIT | Doc PR | This will make the FileValidator::$suffices attribute protected so ImageValidator or any inherited class can access it. It fixes #11110 in the most simple way possible. Commits ------- 859f34e Fixed undefined ImageValidator:: property when uploading an image during functional tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will make the FileValidator::$suffices attribute protected so ImageValidator or any inherited class can access it. It fixes #11110 in the most simple way possible.