[Console] Added verbosity level shorthand methods to OutputInterface #11115
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
They cannot be added in the interface until 3.0 as this is a BC break in the main API of the component. Adding them in the interface for 3.0 is already planned |
This was referenced Aug 23, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
I've added the verbosity level shorthand methods to the interface "Symfony\Component\Console\Output\OutputInterface" as they should always be implemented by classes implementing the interface. Also it makes unit test easier and avoids warnings like:
"The method isVerbose() does not seem to exist on object<Symfony\Compon...put\OutputInterface>." (Scrutinizer-Cis PHP Analyzer)
As this possibly could break backwards compatibility I like to merge into master.