[2.5][Process] Do not redirect output to file handles when output is disabled, simply discard it #11121
Conversation
romainneutron
commented
Jun 14, 2014
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | n/a |
| License | MIT |
|
Please note that this patch oly affect windows users |
| @@ -107,13 +110,11 @@ public function closeUnixPipes() | |||
| /** | |||
| * Returns an array of descriptors for the use of proc_open. | |||
| * | |||
| * @param bool $disableOutput Whether to redirect STDOUT and STDERR to /dev/null or not. | |||
There was a problem hiding this comment.
ProcessPipes are not supposed to be used by anybody. This is actually a private part of Process. I understand this is a bc break in a strict consideration, but I do not consider it breaking anything for people.
For the record, I propose to break BC in this class here again https://github.com/symfony/symfony/pull/10934/files
Should I really provide BC for this one? What other people think?
There was a problem hiding this comment.
I'm just saying it's a bc break. But I'm still ok with it. IMO we should allow minor bc breaks esp. in an "internal" class. Otherwise we strongly slow down further development.
There was a problem hiding this comment.
Then we agree :)
|
👍 |
1 similar comment
|
👍 |
|
Thank you @romainneutron. |
… output is disabled, simply discard it (romainneutron) This PR was merged into the 2.5 branch. Discussion ---------- [2.5][Process] Do not redirect output to file handles when output is disabled, simply discard it | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT Commits ------- b35250f [Process] Do not redirect output to file handles when output is disabled