[Validator] Disallow empty file in FileValidator #11125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
megazoll
commented
Jun 15, 2014
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | yes |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR | symfony/symfony-docs#3746 |
| @@ -29,6 +29,7 @@ class File extends Constraint | |||
| public $notReadableMessage = 'The file is not readable.'; | |||
| public $maxSizeMessage = 'The file is too large ({{ size }} {{ suffix }}). Allowed maximum size is {{ limit }} {{ suffix }}.'; | |||
| public $mimeTypesMessage = 'The mime type of the file is invalid ({{ type }}). Allowed mime types are {{ types }}.'; | |||
| public $disallowEmptyMessage = 'Empty file is not allowed.'; | |||
There was a problem hiding this comment.
Full sentence please. An empty file is not allowed. Also the problem that the file is opened in another program. Is it unique to Windows? Or is it the same bahavior in other OS and programs?
There was a problem hiding this comment.
Problem that the file is opened in another program I can repeat only on Windows. But I can upload file with zero bytes on any OS but that make no sense, that files are useful.
There was a problem hiding this comment.
Ok, if the problem with opened file had been in every OS, then we could added a hint to the validation message. But when it's not the case, then it's ok like this.
|
👍 |
|
Thank you @megazoll. |
fabpot
added a commit
that referenced
this pull request
Jun 16, 2014
…zoll) This PR was merged into the 2.3-dev branch. Discussion ---------- [Validator] Disallow empty file in FileValidator | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | yes | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | symfony/symfony-docs#3746 Commits ------- 1b253cb Disallow empty file in FileValidator
weaverryan
added a commit
to symfony/symfony-docs
that referenced
this pull request
Jul 3, 2014
…oll) This PR was merged into the master branch. Discussion ---------- [Validator] Disallow empty file in FileValidator | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes (symfony/symfony#11125) | Applies to | 2.6+ Commits ------- 80673d5 Disallow empty file in FileValidator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.