[Console] Make sure formatter is the same. #11272
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good but please add a test for this |
The parent constructor will create a new formatter if the $formatter parameter is null This fix avoids that the formatter becomes 2 different instances in $this and $this->stderr
|
Test added. Squashed it into a single commit. |
|
👍 for merge into 2.3 |
|
👍 |
|
Thank you @akimsko. |
fabpot
added a commit
that referenced
this pull request
Jul 2, 2014
This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes #11272). Discussion ---------- [Console] Make sure formatter is the same. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | The parent constructor will create a new formatter if the $formatter parameter is null. This fix avoids that the formatter becomes 2 different instances in $this and $this->stderr, if null was passed to the constructor. Commits ------- 64328d9 [Console] Make sure formatter is the same
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The parent constructor will create a new formatter if the $formatter parameter is null.
This fix avoids that the formatter becomes 2 different instances in $this and $this->stderr, if null was passed to the constructor.