[HttpKernel] Ensure the storage exists before purging it in ProfilerTest #11321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
penyaskito
commented
Jul 5, 2014
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #11319 |
| License | MIT |
| Doc PR | None |
| @@ -79,8 +79,10 @@ protected function setUp() | |||
|
|
|||
| protected function tearDown() | |||
| { | |||
| $this->storage->purge(); | |||
| $this->storage = null; | |||
| if ($this->storage !== null) { | |||
There was a problem hiding this comment.
In Symfony code we usually opt for Yoda conditions, so this line should be:
if (null !== $this->storage) {There was a problem hiding this comment.
Oops, fixed it! Thanks @javiereguiluz
|
Would it be possible to write a test for that? |
| if (null !== $this->storage) { | ||
| $this->storage->purge(); | ||
| $this->storage = null; | ||
| } | ||
|
|
||
| @unlink($this->tmp); |
There was a problem hiding this comment.
Added to the same if block, not sure if it should be a separate one.
|
@dawehner this is already a test. You don't write tests for tests. ^^ |
…ng it in ProfilerTest
|
👍 |
1 similar comment
|
👍 |
|
Thank you @penyaskito. |
fabpot
added a commit
that referenced
this pull request
Jul 6, 2014
… in ProfilerTest (penyaskito) This PR was merged into the 2.3 branch. Discussion ---------- [HttpKernel] Ensure the storage exists before purging it in ProfilerTest | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11319 | License | MIT | Doc PR | None Commits ------- eb63270 bug #11319 [HttpKernel] Ensure the storage exists before purging it in ProfilerTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.