add XSD to PHPUnit configuration #11329
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
@fabpot What about simplifying the phpunit config by avoiding to repeat the defaults ? The Otherwise, 👍 for adding the XSD |
|
@stof I like being explicit, but as this file does not change that much over time, we can also remove the defaults. Can be done in another PR though. |
|
Thank you @craue. |
fabpot
added a commit
that referenced
this pull request
Jul 7, 2014
This PR was merged into the 2.3 branch. Discussion ---------- add XSD to PHPUnit configuration | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | -- | License | MIT | Doc PR | -- The syntax check functionality has been removed in PHPUnit 3.6 already. But there's no Composer constraint for PHPUnit, so you can never know which version will actually be used to run tests. Let me know what you think. Commits ------- 84b5581 added XSD to PHPUnit configuration
fabpot
added a commit
that referenced
this pull request
Jul 8, 2014
This PR was merged into the 2.3 branch. Discussion ---------- remove defaults from PHPUnit configuration | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | -- | License | MIT | Doc PR | -- Follow-up to #11329. Commits ------- afc4930 removed defaults from PHPUnit configuration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The syntax check functionality has been removed in PHPUnit 3.6 already. But there's no Composer constraint for PHPUnit, so you can never know which version will actually be used to run tests. Let me know what you think.