Reverse DateTimeToStringTransformer must use format #1134
Conversation
|
Can you also add additional test that would cover use case you mentioned ? |
|
Yes, I will add additional test. But before, I met two bugs (one for "DateTime::createFromFormat"and the other one for "DateTime") :
The solution looks like that: public function reverseTransform($value)
{
if (empty($value)) {
return null;
}
if (!is_string($value)) {
throw new UnexpectedTypeException($value, 'string');
}
try {
$dateTime = \DateTime::createFromFormat($this->format, $value, new \DateTimeZone($this->outputTimezone));
$last_errors = \DateTime::getLastErrors();
if($last_errors['warning_count'] > 0 || $last_errors['error_count'] > 0){
throw new \Exception('One message...');
}
if ($this->inputTimezone !== $this->outputTimezone) {
$dateTime->setTimeZone(new \DateTimeZone($this->inputTimezone));
}
} catch (\Exception $e) {
throw new TransformationFailedException($e->getMessage(), $e->getCode(), $e);
}
return $dateTime;
}But, have you suggestions to replace the "One message..." (inside the Exception). Or other solutions? |
|
@hlecorche These are not a Symfony bugs but the expected behavior of DateTime objects. |
|
@stof: Yes, I agree, I expressed myself badly. It is not a bug, but do we accept this behavior for a form? (A user can give one invalid date) And, with "DateTime::createFromFormat", we must check (because, contrary to "new DateTime()", it doesn't throw exception. |
|
I propose this code: public function reverseTransform($value)
{
if (empty($value)) {
return null;
}
if (!is_string($value)) {
throw new UnexpectedTypeException($value, 'string');
}
try {
$dateTime = \DateTime::createFromFormat($this->format, $value, new \DateTimeZone($this->outputTimezone));
$last_errors = \DateTime::getLastErrors();
if($last_errors['warning_count'] > 0 || $last_errors['error_count'] > 0){
throw new \Exception('Date is invalid.');
}
if ($this->inputTimezone !== $this->outputTimezone) {
$dateTime->setTimeZone(new \DateTimeZone($this->inputTimezone));
}
} catch (\Exception $e) {
throw new TransformationFailedException($e->getMessage(), $e->getCode(), $e);
}
return $dateTime;
}This code allows :
Do you agree? Do you have any suggestions? If you agree, I will commit this code and will add additional tests. |
In DateTimeToStringTransformer, transform function uses "format" but not "reverseTransform".
If the format is different than "Y-m-d", reverseTransform throws TransformationFailedException.