[Validator] Improve UserPassword message #11383
Conversation
|
You should update translations in the same PR. Also, you need to update the message source in all the translation files (not just English). |
|
@jakzal How's that? |
|
Hmm, I don't know why these translation fixes would cause the build to fail so extensively. Are quotes not allowed in the xlf files? |
|
The problems are not related to your changes, so no worries. |
|
changing the source of the translation is a bC break: if a project redefines the translation message or adds another locale, it will not be used anymore after this change. The safe way would be to change it only in the English translation message (this is an advantage of not using the English string as source btw) |
|
@redstar504 Stof is right - I think we will need to change only the english translation. I'm not sure if we can/should break BC, even though I'd love to have the default message be the correct English. Can someone else back this up to be sure? I don't want to keep making @redstar504 change his PR if we are able to break this translation key BC. |
|
IMO, we should only change the English translation in 2.3 and change the key in master. |
|
Okay in that case this PR is 👍, and I will send separate PR for 2.3? |
|
@redstar504 yes, please. |
|
Okay done in #11387. |
… (redstar504) This PR was merged into the 2.3 branch. Discussion ---------- [2.3] [Validator] Fix UserPassword validator translation | Q | A | ------------- | --- | Fixed tickets | None | License | MIT Fixes the UserPassword translation message only for 2.3 as discussed in #11383. Commits ------- 73d50ed Fix UserPassword validator translation
… (redstar504) This PR was merged into the 2.3 branch. Discussion ---------- [2.3] [Validator] Fix UserPassword validator translation | Q | A | ------------- | --- | Fixed tickets | None | License | MIT Fixes the UserPassword translation message only for 2.3 as discussed in symfony/symfony#11383. Commits ------- 73d50ed Fix UserPassword validator translation
|
If I'm not mistaken this can be merged now? |
|
@redstar504 Can you add a note about this "BC break" in the Validator changelog? |
|
Done. @fabpot |
|
👍 |
|
Thank you @redstar504. |
This PR was squashed before being merged into the 2.6-dev branch (closes #11383). Discussion ---------- [Validator] Improve UserPassword message | Q | A | ------------- | --- | Fixed tickets | None | License | MIT This validator message is not proper English. Commits ------- d57471e [Validator] Improve UserPassword message
… (redstar504) This PR was merged into the 2.3 branch. Discussion ---------- [2.3] [Validator] Fix UserPassword validator translation | Q | A | ------------- | --- | Fixed tickets | None | License | MIT Fixes the UserPassword translation message only for 2.3 as discussed in symfony/symfony#11383. Commits ------- 73d50ed Fix UserPassword validator translation
This validator message is not proper English.