Fix for issue 11049 #11398
Closed
Fix for issue 11049 #11398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BC break: YES |
| */ | ||
| public function initialize(ExecutionContextInterface $context); | ||
| public function initialize($context); |
There was a problem hiding this comment.
hmm, changing this interface is indeed a BC break.
@webmozart what would be the right way to handle the 2.5 API there ?
|
Won't fix. See my comment to #11049 for more explanation. |
|
given that the new context interface extends the legacy one, this BC break is indeed not necessary |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the original ticket.
I've added support for the new
Symfony\Component\Validator\Context\ExecutionContextInterfaceinSymfony\Component\Validator\ConstraintValidator, so the new Validation api can be used.