Skip to content

[DomCrawler] Added node name getter #11426

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 25, 2014
Merged

Conversation

fejese
Copy link
Contributor

@fejese fejese commented Jul 20, 2014

[DomCrawler] Added node name getter

Based on the use case came up in a SO question (http://stackoverflow.com/questions/22564465/getting-the-tag-name-of-a-element-crawled-with-domcrawler-in-php) I propose a new helper function to get the name of the active node

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR symfony/symfony-docs#4039

(Follow up of #11351)

*
* @throws \InvalidArgumentException When current node is empty
*
* @api
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @api should be removed.

@fabpot
Copy link
Member

fabpot commented Jul 25, 2014

👍

@fabpot
Copy link
Member

fabpot commented Jul 25, 2014

Thank you @fejese.

@fabpot fabpot merged commit 2fee576 into symfony:master Jul 25, 2014
fabpot added a commit that referenced this pull request Jul 25, 2014
This PR was merged into the 2.6-dev branch.

Discussion
----------

[DomCrawler] Added node name getter

[DomCrawler] Added node name getter

Based on the use case came up in a SO question (http://stackoverflow.com/questions/22564465/getting-the-tag-name-of-a-element-crawled-with-domcrawler-in-php) I propose a new helper function to get the name of the active node

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        | symfony/symfony-docs#4039

(Follow up of #11351)

Commits
-------

2fee576 [DomCrawler] Added node name getter
@fejese fejese deleted the node-name-getter branch July 25, 2014 06:30
weaverryan added a commit to symfony/symfony-docs that referenced this pull request Aug 16, 2014
This PR was merged into the master branch.

Discussion
----------

[DomCrawler] Added node name getter

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes (symfony/symfony#11426)
| Applies to    | all
| Fixed tickets |

Commits
-------

09c9af4 [DomCrawler] Added node name getter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants