Add deprecation note #11432
Closed
Add deprecation note #11432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is the benefit of changing the priority in the bundle? It looks like changing them here would benefit Silex and other users of the bridge, no? |
|
Two things:
But yes I would say the subscriber should be adjusted then so the next |
fabpot
added a commit
that referenced
this pull request
Jul 25, 2014
This PR was merged into the 2.4 branch. Discussion ---------- [MonologBridge] fixed Console handler priorities | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11432 | License | MIT | Doc PR | n/a alternative to #11432 ping @Seldaek Commits ------- bdf874f [MonologBridge] fixed Console handler priorities
fabpot
added a commit
to symfony/monolog-bridge
that referenced
this pull request
Jul 25, 2014
This PR was merged into the 2.4 branch. Discussion ---------- [MonologBridge] fixed Console handler priorities | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11432 | License | MIT | Doc PR | n/a alternative to symfony/symfony#11432 ping @Seldaek Commits ------- bdf874f [MonologBridge] fixed Console handler priorities
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a note because I moved this into the bundle in symfony/monolog-bundle@227bbee to be able to tweak the priorities.