[Form] Automated label generation for forms #11456
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public function buildView(FormView $view, FormInterface $form, array $options) | ||
| { | ||
| if ($options['label'] === null) { |
There was a problem hiding this comment.
Should be null === $options['label'] (also in the expressions below).
|
@webmozart do you agree on the implementation? I'll work on documentation PRs as soon as the implementation is validated here |
|
See https://github.com/Elao/ElaoFormTranslationBundle if you don't know already it. |
| @@ -177,6 +177,11 @@ private function registerFormConfiguration($config, ContainerBuilder $container, | |||
| $config['form']['csrf_protection']['enabled'] = $config['csrf_protection']['enabled']; | |||
| } | |||
|
|
|||
| if (array_key_exists('auto_label', $config['form'])) { | |||
| $loader->load('form_auto_label.xml'); | |||
| $container->setParameter('form.type_extension.auto_label.auto_label', $config['form']['auto_label']); | |||
There was a problem hiding this comment.
the parameter name looks weird with auto_label being duplicated. form.type_extension.auto_label.format might be better
|
Thanks for the idea and PR @alexandresalome! I had a little different solution in mind, which I uploaded in #12050. Please let me know whether this is convenient for you. Cheers! |
webmozart
added a commit
that referenced
this pull request
Sep 30, 2014
This PR was merged into the 2.6-dev branch. Discussion ---------- [Form] Added "label_format" option | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11456 | License | MIT | Doc PR | TODO This PR replaces #11456. It adds a "label_format" option which allows to configure a format for generating labels. Two placeholders are available: `%name%` and `%id%`. **Feedback wanted**: Should we change the placeholders to `{{ name }}` and `{{ id }}`? The option is inherited from the parent form if not set explicitly on a field: ```php $form = $this->createForm('myform', $data, array('label_format' => 'form.label.%id%')); ``` Follow-up PR: Make the default label format and translation domain configurable in config.yml. Commits ------- aad442d [Form] Added "label_format" option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion started in #11298
This PR is about adding an option to automate the label generation for forms:
This option would be useful for big I18Ned applications with standardized label form translations. We could also add an option for a default translation_domain.
I started this work as a third-party extension, because most applications don't need it, so the footprint is null for them.
What is your advice on it?