[Validator] prevent unnecessary calls inside ExecutionContext #11463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
May this PR introduce a BC if someone had overrided |
|
IMO such thing is not convered by our BC promise when not extra designed to be extended. Otherwise we would need to always use the public getter within each class, which we almost never do. Even here in this case, there is also a |
|
👍 |
|
Thank you Tobias. |
webmozart
added a commit
that referenced
this pull request
Jul 28, 2014
…ntext (Tobion) This PR was merged into the 2.5 branch. Discussion ---------- [Validator] prevent unnecessary calls inside ExecutionContext | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT Small performance improvement by preventing calls to `PropertyPath::append($this->propertyPath, $subPath)` when not needed. Commits ------- d6d462a [Validator] do not call getter inside ExecutionContext to prevent unnecessary calls
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small performance improvement by preventing calls to
PropertyPath::append($this->propertyPath, $subPath)when not needed.