Skip to content

fixing B/C break with validatePropertyValue #11478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fixing B/C break with validatePropertyValue #11478

wants to merge 1 commit into from

Conversation

oleg-andreyev
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #11139
License MIT
Doc PR none

@oleg-andreyev oleg-andreyev changed the title #11139 fixing B/C break #11139 fixing B/C break with validatePropertyValue Jul 25, 2014
@oleg-andreyev oleg-andreyev changed the title #11139 fixing B/C break with validatePropertyValue fixing B/C break with validatePropertyValue Jul 25, 2014
@Tobion
Copy link
Contributor

Tobion commented Jul 26, 2014

This requires a change to ContextualValidatorInterface and ValidatorInterface that you can also pass a string as class name.

@oleg-andreyev
Copy link
Contributor Author

But should this method have this ability? /cc @webmozart @fabpot

@webmozart
Copy link
Contributor

Thanks for submitting this PR! :) I fixed the bug in a slightly different way in #11498 now.

@webmozart webmozart closed this Jul 28, 2014
@oleg-andreyev oleg-andreyev deleted the fixing-bc-validate-property-value branch July 29, 2014 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oleg-andreyev @Tobion @webmozart