Skip to content

[HttpFoundation] Removed HTTP statuses magic constants #11547

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

vilartoni
Copy link

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

@javiereguiluz
Copy link
Member

@vilartoni first of all, thanks for your contribution to Symfony project!

Unfortunately, the same change that you are proposing was refused a time ago (see #11401). The reason is that this change makes code less readable with no clear benefit.

The HTTP constants can be very useful for end-user code, but for internal Symfony code it was decided that they are not that useful.

@vilartoni
Copy link
Author

@javiereguiluz I agree to disagree ;)

Thanks for your quick response.

@vilartoni vilartoni closed this Aug 2, 2014
@dawehner
Copy link
Contributor

Oh just to be sure, this list REALLY handy, so a couple of Drupal code (both core and contrib) relies on the list being there.

@javiereguiluz
Copy link
Member

@dawehner I'm glad that this list comes in handy for Drupal. For the internal source code of Symfony it was decided that it was not that useful, but this may change in the future!

@fabpot
Copy link
Member

fabpot commented Oct 22, 2014

The list is there to stay, but we don't use it internally.

@vilartoni
Copy link
Author

@dawehner You don't need to worry. What has been rejected are only the changes proposed in this PR ;-)

@dawehner
Copy link
Contributor

Cool. Just wanted to ensure that you don't drop things accidentally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants