Skip to content

[YAML] added ability for substitute aliases when mapping is on single line #11569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

fabpot
Copy link
Member

@fabpot fabpot commented Aug 5, 2014

This PR was submitted on the symfony/Yaml read-only repository and moved automatically to the main Symfony repository (closes symfony/yaml#9).

At present parser only substitutes aliases when mapping is in a multiline.
When the alias is used in the mapping stored in a single line, alias substitution doesn't work.

So I modified Parser to fix it.

@@ -407,6 +407,59 @@ private function moveToPreviousLine()
}

/**
* Substitute from alias where is used a <<
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be something like "where a << is used"

@romainneutron romainneutron changed the title added ability for substitute aliases when mapping is on single line [YAML] added ability for substitute aliases when mapping is on single line Aug 11, 2014
@stof
Copy link
Member

stof commented Aug 14, 2014

related to #11665

fabpot added a commit that referenced this pull request Aug 27, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

[YAML] resolve variables in inlined YAML

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #11665
| License       | MIT
| Doc PR        |

#11569 does not resolve variables in inline YAML.

Commits
-------

45a5863 [YAML] resolve variables in inlined YAML
@fabpot fabpot closed this Aug 27, 2014
@xabbuh
Copy link
Member

xabbuh commented Aug 27, 2014

@fabpot Actually, I don't think that this can be closed. I didn't fix anything related to alias substitution in #11677. The tests added here would still fail.

@fabpot fabpot reopened this Aug 27, 2014
@fabpot fabpot closed this Jan 25, 2016
@fabpot
Copy link
Member Author

fabpot commented Jan 25, 2016

@xabbuh Would you like to take over this one?

@xabbuh
Copy link
Member

xabbuh commented Nov 20, 2017

Thank you for starting this @nexGN. It took me some time, but your PR is now going to be finished in #25043.

fabpot added a commit that referenced this pull request Nov 23, 2017
…s on single line (Michał Strzelecki, xabbuh)

This PR was merged into the 2.7 branch.

Discussion
----------

[Yaml] added ability for substitute aliases when mapping is on single line

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #11569
| License       | MIT
| Doc PR        |

Commits
-------

dd26c80 substitute aliases in inline mappings
675a3fe added ability for substitute aliases when mapping in YAML is on single line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants