[DoctrineBridge] Changed UniqueEntityValidator to use the 2.5 Validation API #11582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
webmozart
commented
Aug 6, 2014
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #11578 |
| License | MIT |
| Doc PR | - |
| @@ -79,6 +80,9 @@ public function getInstance(Constraint $constraint) | |||
| case self::FORM_BASE_NAMESPACE.'\\Form': | |||
| $name = self::FORM_BASE_NAMESPACE.'\\LegacyFormValidator'; | |||
| break; | |||
| case self::DOCTRINE_BASE_NAMESPACE.'\\UniqueEntity': | |||
| $name = self::DOCTRINE_BASE_NAMESPACE.'\\LegacyUniqueEntityValidator'; | |||
| break; | |||
There was a problem hiding this comment.
This won't work, because the valdiator is registered as a service (it has some dependencies)
|
@stof That's indeed much better. I'll remove the duplicated legacy classes everywhere. |
|
See #11587 |
|
|
||
| /** | ||
| * @since 2.5.4 | ||
| * @author Bernhard Schussek <bschussek@gmail.com> |
There was a problem hiding this comment.
we generally don't use @author on tests (and @since are not really needed for tests either IMO)
There was a problem hiding this comment.
There are quite some tests that have the @author keyword. It's in my file template and I don't think there's any benefit in removing it.
|
👍 |
1 similar comment
|
👍 |
webmozart
added a commit
that referenced
this pull request
Aug 7, 2014
…2.5 Validation API (webmozart) This PR was merged into the 2.5 branch. Discussion ---------- [DoctrineBridge] Changed UniqueEntityValidator to use the 2.5 Validation API | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11578 | License | MIT | Doc PR | - Commits ------- f45f1ab [DoctrineBridge] Changed UniqueEntityValidator to use the 2.5 Validation API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.