[Validator] Added ConstraintViolation::getConstraint() #11657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @internal Used by the validator engine. Should not be called by user | ||
| * code. | ||
| */ | ||
| public function setConstraint(Constraint $constraint); |
There was a problem hiding this comment.
Looking at the BC promise, this can must be documented in the UPGRADE-2.6.md file, mustn't it?
There was a problem hiding this comment.
Good catch! Thanks.
There was a problem hiding this comment.
and also in the Validator changelog
|
ping @symfony/deciders |
|
|
||
| * The internal method `setConstraint()` was added to | ||
| `Symfony\Component\Validator\Context\ExecutionContextInterface`. With | ||
| this method, the context is informed about constraint that is currently |
There was a problem hiding this comment.
Missing "the" before constraint?
|
👍 |
| @@ -73,11 +74,16 @@ class ConstraintViolationBuilder implements ConstraintViolationBuilderInterface | |||
| private $plural; | |||
|
|
|||
| /** | |||
| * @var Constraint|null | |||
There was a problem hiding this comment.
cannot be null according to the constructor
|
I'm 👍 on this one, just address @Tobion comment |
|
👍 |
webmozart
added a commit
that referenced
this pull request
Aug 19, 2014
… (webmozart) This PR was merged into the 2.6-dev branch. Discussion ---------- [Validator] Added ConstraintViolation::getConstraint() | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #5050 | License | MIT | Doc PR | - This PR adds a `getConstraint()` method to the `ConstraintViolation` in order to access the constraint causing the violation. Related to #7276, #7273 and #9691. Commits ------- ce1d209 [Validator] Added ConstraintViolation::getConstraint()
This was referenced Aug 19, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
getConstraint()method to theConstraintViolationin order to access the constraint causing the violation.Related to #7276, #7273 and #9691.