[Routing] fix handling of nullable XML attributes #11672
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
| $routeCollection = $loader->load('null_values.xml'); | ||
| $route = $routeCollection->get('blog_show'); | ||
|
|
||
| $this->assertNull($route->getDefault('foo')); |
There was a problem hiding this comment.
this alone doesnt test anything since getDefault also return null when it does not exist. so u need to also use hasDefault
|
@Tobion I didn't add any tests for |
|
Why not. It's easy and makes sure the implementation does not only check |
As @Tobion pointed out in symfony#11394, true and 1 are valid values in boolean XML attributes. The XmlFileLoader didn't handle 1 values properly.
|
Okay, added them. |
|
👍 |
2 similar comments
|
👍 |
|
👍 |
|
Thanks for fixing this bug @xabbuh. |
Tobion
added a commit
that referenced
this pull request
Aug 20, 2014
This PR was merged into the 2.3 branch. Discussion ---------- [Routing] fix handling of nullable XML attributes | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | As @Tobion pointed out in #11394, ``true`` and ``1`` are valid values in boolean XML attributes. The XmlFileLoader didn't handle ``1`` values properly. Commits ------- 7b4d4b6 fix handling of nullable XML attributes
|
My first merge :) |
|
@Tobion Thanks for all your feedback! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As @Tobion pointed out in #11394,
trueand1are valid values in boolean XML attributes. The XmlFileLoader didn't handle1values properly.