[TwigBundle] Remove hard dependency of RequestContext in AssetsExtension #11749
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -101,6 +110,10 @@ private function ensureUrlIsAbsolute($url) | |||
| return $url; | |||
| } | |||
|
|
|||
| if (!$this->context) { | |||
| throw new \RuntimeException("To ensure a URL as absolute the Symfony Routing component is required."); | |||
There was a problem hiding this comment.
message should be single-quoted.
| @@ -13,6 +13,7 @@ | |||
|
|
|||
| use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface; | |||
| use Symfony\Component\DependencyInjection\ContainerBuilder; | |||
| use Symfony\Component\DependencyInjection\Reference; | |||
There was a problem hiding this comment.
Absolutely, sorry for missing it. Done.
5f8c884 to
8e38cbd
Compare
| @@ -101,6 +111,10 @@ private function ensureUrlIsAbsolute($url) | |||
| return $url; | |||
| } | |||
|
|
|||
| if (!$this->context) { | |||
| throw new \RuntimeException('To ensure a URL as absolute the Symfony Routing component is required.'); | |||
There was a problem hiding this comment.
This message looks weird to me. "To ensure a URL as absolute..." -> "To generate an absolut URL for an asset, ..."
|
👍 |
1 similar comment
|
👍 |
|
Thank you @pgodel. |
fabpot
added a commit
that referenced
this pull request
Aug 27, 2014
…ssetsExtension (pgodel) This PR was merged into the 2.5 branch. Discussion ---------- [TwigBundle] Remove hard dependency of RequestContext in AssetsExtension | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11466 | License | MIT | Doc PR | - #10451 introduced the requirement of RequestContext in AssetsExtension. This is only needed when generating absolute URLs for assets. When sending emails with Twig from the CLI, the router may not be present and most times is not required. This PR attempts to remove the hard dependency and set RequestContext if the router is present according to issue #11466. Commits ------- 5ad4d8a Remove hard dependency of RequestContext in AssetsExtension
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#10451 introduced the requirement of RequestContext in AssetsExtension. This is only needed when generating absolute URLs for assets. When sending emails with Twig from the CLI, the router may not be present and most times is not required.
This PR attempts to remove the hard dependency and set RequestContext if the router is present according to issue #11466.