At the end the solution was much easier, I created originally a new Collection of routes for the routes with priority and appended that one to the end of the original Collection, now I changed the order, I append the original routes to the end of the new Collection.

What if I set a priority with a negative value (as I can do for events)? Your code will not place my route AFTER the routes without priority?
I think you should not separates routes with priorities, from routes without priorities. (And the code will be simpler

foreach ($this->reader->getMethodAnnotations($method) as $annot) {
    if ($annot instanceof $this->routeAnnotationClass) {
        if (null === $priority = $annot->getOption('priority')) {
            $priority = 0;
        }
        $this->routesWithPriority[$priority][] = array($annot, $globals, $class, $method);
    }
}

or simpler $priority = (int) $annot->getOption('priority');

You are totally right Jeremy, I changed it as you suggested.

I don't like the way the priority are working currently. Currently, the order of routes depends on the order of imports, and on the order inside the imported resource. This priority creates a new way for routes loaded through annotations, with interactions between several imported resources but not with resources from other formats.
I see 2 consistent solutions:

• support the priority everywhere. It would be added as a route option and the sorting would be done at the end. This is bad IMO as it makes it far too complex to understand the final ordering, and removes control on the ordering from the app (as a bundle could decide to use a higher priority). I'm -1 on this approach
• consider that the priority is only about ordering the routes loaded by annotations in a given class (because contrary to YAML or XML, it is hard to control the order in which annotated methods are found when iterating).

I would vote for the second approach. And the implementation would be easy:

• revert any change done in the AnnotationFileLoader and the AnnotationDirectoryLoader
• change the class member $routesWithPriority to a local variable in the AnnotationClassLoader::load method (which solves the issue with the loader being stateful btw)

hmm, actually, the related ticket talks about controlling the order of files. This is much more complex (and is exactly the reason why the DirectoryLoader has been rejected from core)

Yes, the original was that, but then if it's only for the directory, then it would be also a bit confusing to use it only there and why not in everywhere for annotations. But I also understand your problem here.

Well, the issue is that ordering controllers compared to each other requires a different way to sort them, handled by the AnnotationDirectoryLoader, and sorting the controllers compared to each other only, not allowing to mix routes from each controller

So I should implement it like I compare them only in the DirectoryLoader right?

@ghostika if you want to solve the ordering of controllers, what should be found is a way to sort the different sub-collections loaded in the AnnotationDirectoryLoader. I don't know how we should define the priority then

Closing this stale PR as the current implementation is not desirable.

cherry picked, nice quick solutation still waiting for this feature in major symfony releases ... ;-) majbe not desirable for the team but desired from the people use symfony ;-)