[Security] Add more tests for StringUtils::equals #11808
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you use a dataprovider instead of multiples asserts? |
|
👍 |
36d42e6 to
f9c08a3
Compare
|
@fabpot The use of the short array notation (introduced in PHP 5.4) is a bug in fabbot? |
|
@dunglas Symfony should be compatible with php 5.3 |
|
@jeremy-derusse yes I know, I'm talking about the error reported by fabbot: http://fabbot.io/report/symfony/symfony/11808/f9c08a32747428212be3f10a4deccf00815fd017 |
|
@dunglas I've just removed the check for the short array syntax. The report is more relevant now. |
f9c08a3 to
a676863
Compare
|
@fabpot thanks. CS fixed. |
|
👍 |
1 similar comment
|
👍 |
|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Sep 2, 2014
This PR was merged into the 2.4 branch. Discussion ---------- [Security] Add more tests for StringUtils::equals | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | n/a More tests for `StringUtils::equals`. Commits ------- a676863 [Security] Add more tests for StringUtils::equals
|
reverting as not all those tests actually pass. |
fabpot
added a commit
that referenced
this pull request
Sep 3, 2014
* 2.4: Revert "minor #11808 [Security] Add more tests for StringUtils::equals (dunglas)"
fabpot
added a commit
that referenced
this pull request
Sep 3, 2014
* 2.5: Revert "minor #11808 [Security] Add more tests for StringUtils::equals (dunglas)"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More tests for
StringUtils::equals.