Skip to content

Conversation

DQNEO
Copy link
Contributor

@DQNEO DQNEO commented Aug 31, 2014

$server is the sixth argument, not fourth.

Q A
Bug fix? no,
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

@DQNEO DQNEO changed the title fix comment: not fourth but sixth argument [HttpFoundation] fix comment: not fourth but sixth argument Aug 31, 2014
@fabpot
Copy link
Member

fabpot commented Sep 1, 2014

Good catch, thanks @DQNEO.

fabpot added a commit that referenced this pull request Sep 1, 2014
…ent (DQNEO)

This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #11811).

Discussion
----------

[HttpFoundation] fix comment: not fourth but sixth argument

$server is the **sixth** argument, not fourth.

| Q             | A
| ------------- | ---
| Bug fix?      | no,
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

42841e8 fix comment: not fourth but sixth argument
@fabpot fabpot closed this Sep 1, 2014
@DQNEO DQNEO deleted the fix_comment_in_test branch September 1, 2014 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants