[Intl] Fixed a few bugs in TextBundleWriter #11906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a140d35 to
5d74d6e
Compare
| /** | ||
| * Thrown when a method argument had an unexpected type. | ||
| * | ||
| * @since 2.5 |
There was a problem hiding this comment.
The PR is on 2.3, so this is wrong.
5d74d6e to
137d9ad
Compare
|
Updated. |
| $keys = array_keys($value); | ||
| $intKeys = count($value) === count(array_filter($keys, 'is_int')) && | ||
| // check that the keys are 0-indexed and ascending | ||
| array_sum($keys) === array_sum(range(0, count($keys)-1)); |
There was a problem hiding this comment.
this does not check that they are ascending actually.
The way we check this in other places in Symfony is using keys === range(0, count($keys) - 1)
There was a problem hiding this comment.
Thanks, fixed. I also added another test for this.
137d9ad to
397ccb0
Compare
| $intValues = count($value) === count(array_filter($value, 'is_int')); | ||
|
|
||
| $keys = array_keys($value); | ||
| $intKeys = count($value) === count(array_filter($keys, 'is_int')) && |
There was a problem hiding this comment.
this first condition is not needed. The second part is enough
397ccb0 to
7b4a35a
Compare
|
ping @symfony/deciders |
|
👍 |
webmozart
added a commit
that referenced
this pull request
Sep 15, 2014
This PR was merged into the 2.3 branch. Discussion ---------- [Intl] Fixed a few bugs in TextBundleWriter | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - See the included test cases for more information. This code was extracted from #9206. Commits ------- 7b4a35a [Intl] Fixed a few bugs in TextBundleWriter
webmozart
added a commit
that referenced
this pull request
Sep 30, 2014
This PR was merged into the 2.3 branch. Discussion ---------- [Intl] Integrated ICU data into Intl component #1 | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11447, #10807 | License | MIT | Doc PR | - This PR is an alternative implementation to #11884. It depends on ~~#11906~~ and ~~#11907~~ being merged first (~~these are included in the diff until after a merge+rebase~~ merged+rebased now). With this PR, the ICU component becomes obsolete. The ICU data is bundled with Intl in two different formats: JSON and the binary ICU resource bundle format (version 2) readable by PHP's `\ResourceBundle` class. For a performance comparison between the two, see my [benchmark](/webmozart/json-res-benchmark). ~~The data is contained in two zip files: json.zip (2.6MB) and rb-v2.zip (3.8MB). The handler~~ ```php \Symfony\Component\Intl\Composer\ScriptHandler::decompressData() ``` ~~needs to be added as Composer hook and decompresses the data after install/update.~~ The data is included as text/binary now. Git takes care of the compression. Before this PR can be merged, I would like to find out what the performance difference between the two formats is in real applications. For that, I need benchmarks from some real-life applications which use ICU data - e.g. in forms (language drop-downs, country selectors etc.) - for both the JSON and the binary data. You can force either format to be used by hard-coding the return value of `Intl::detectDataFormat()` to `Intl::JSON` and `Intl::RB_V2` respectively. I'll also try to create some more realistic benchmarks. If JSON is not significantly slower/takes up significantly more memory than the binary format, we can drop the binary format altogether. Commits ------- be819c1 [Intl] Integrated ICU data into Intl component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the included test cases for more information. This code was extracted from #9206.