[DependencyInjection] Added support for closure as a factory method #11968
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ff4be2 to
958ab11
Compare
958ab11 to
000b348
Compare
000b348 to
75fac20
Compare
|
2.6 is going to have a new better way to register factories. See #12008 |
|
Yes, that PR looks nice. I'll fix and rebase my PR after merging that one. |
|
I agree this should wait for #12008. Defining a closure in factoryMethod is wrong, as a closure is not a method. |
|
@unkind the PR has been merged |
|
That's good. I'll make my changes this weekend. |
|
I wait for #12065. |
|
I've opened new PR: #12115. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've detached closure's part from #11953. Furthermore, there is no SuperClosure dependency anymore, because I'm not sure if I have to create bridge package by myself.