[Security] Fix BC break introduced in #10694 #12049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixing the BC break is indeed needed. It is a bit unfortunate that we must make the AuthenticationManager optional, but this is needed for BC anyway |
|
👍 |
|
However, I suspect you forgot to update the tests of the class |
|
I fixed the tests in 2763227 |
fabpot
added a commit
that referenced
this pull request
Sep 27, 2014
…ron) This PR was merged into the 2.6-dev branch. Discussion ---------- [Security] Fix BC break introduced in #10694 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12034 | License | MIT Not sure about this fix, @stof 'ing welcome Commits ------- b2183aa [Security] Fix BC break introduces in #10694
|
Actually, this fix is wrong :( I fixed it in 4e0021b |
|
thanks @fabpot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure about this fix, @stof 'ing welcome