[DX] Moved Security constants to a final class instead of a long named interface #12074
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I love this proposal. Thanks @iltar for your work. I really can't think of any reason for not merging this. |
|
👍 |
|
Isnt this a BC break as the constants are now located a new place? |
|
@henrikbjorn It's a BC break on the master branch only. They have been moved to that interface in my other PR. This change is currently not present in any tag. |
|
👍 I like it :) |
|
👍 |
|
Thank you @iltar. |
fabpot
added a commit
that referenced
this pull request
Sep 29, 2014
…f a long named interface (iltar) This PR was merged into the 2.6-dev branch. Discussion ---------- [DX] Moved Security constants to a final class instead of a long named interface | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | symfony/symfony-docs#4188 This PR is based on feedback from the documentation repository. The DX suggestion was to rename the new `SecuritySessionStorageInterface` to `Security`. This would make it easier to use the constants before 2.6 is released. In this PR I have also update all usages of this constant because an open PR is now merged which used those constants. List of changes: - SecurityBundle, usage of constants - Security Component (core & http), usage of constants - Tests, usage of constants - Added a test to verify the sync from `Security` to `SecurityContextInterface` for BC purposes Commits ------- b23084a [DX] Moved constants to a final class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on feedback from the documentation repository. The DX suggestion was to rename the new
SecuritySessionStorageInterfacetoSecurity. This would make it easier to use the constants before 2.6 is released. In this PR I have also update all usages of this constant because an open PR is now merged which used those constants.List of changes:
SecuritytoSecurityContextInterfacefor BC purposes