Skip to content

[HttpKernel] fix composer.json #12078

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2014
Merged

Conversation

nicolas-grekas
Copy link
Member

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

This fixes the composer.json of HttpKernel

@nicolas-grekas
Copy link
Member Author

Oh and I also put a symfony/translation instead of symfony/translator in HttpKernel's composer.json

@nicolas-grekas
Copy link
Member Author

And a missing symfony/var-dumper in require-dev...

@fabpot
Copy link
Member

fabpot commented Sep 30, 2014

The doc block change should happen in 2.3, but the other changes are only for master. Can you open another PR for the doc block fix for 2.3?

@nicolas-grekas nicolas-grekas changed the title [EventDispatcher] fix doc bloc on EventDispatcherInterface [HttpKernel] fix composer.json Sep 30, 2014
@nicolas-grekas
Copy link
Member Author

See #12078

@stof
Copy link
Member

stof commented Sep 30, 2014

👍

@fabpot
Copy link
Member

fabpot commented Sep 30, 2014

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 7bb768d into symfony:master Sep 30, 2014
fabpot added a commit that referenced this pull request Sep 30, 2014
This PR was merged into the 2.6-dev branch.

Discussion
----------

[HttpKernel] fix composer.json

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This fixes the composer.json of HttpKernel

Commits
-------

7bb768d [HttpKernel] fix composer.json
@nicolas-grekas nicolas-grekas deleted the doc-block-fix branch October 1, 2014 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants