Skip to content

Tree builder #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
2 commits merged into from
Mar 9, 2011
Merged

Tree builder #121

2 commits merged into from
Mar 9, 2011

Conversation

stof
Copy link
Member

@stof stof commented Feb 27, 2011

This removes duplicated code. A VariableNode has exactly the same configuration than a ScalarNode as it is a way to accept an array treated as scalar for the merging.

@fabpot
Copy link
Member

fabpot commented Feb 27, 2011

This breaks the tests.

@stof
Copy link
Member Author

stof commented Feb 27, 2011

Ah right, the type hint needs to be changed.

@stof
Copy link
Member Author

stof commented Feb 27, 2011

As the PR making ScalarNode inheriting from VariableNode has been merged the type hint could simply be changed to VariableNode in the configure method. I will rebase on master to change this.

@stof
Copy link
Member Author

stof commented Feb 27, 2011

This works now.

SofHad pushed a commit to SofHad/symfony that referenced this pull request Oct 12, 2015
This PR was merged into the master branch.

Discussion
----------

Mistranslation en to de

This is a small mistranslation. (FÜr to Für)

Commits
-------

8f4a2d4 Mistranslation en to de
jderusse pushed a commit to jderusse/symfony that referenced this pull request Mar 30, 2020
derrabus added a commit to derrabus/symfony that referenced this pull request Jul 26, 2023
…arsed body (nicolas-grekas)

This PR was merged into the 2.3 branch.

Discussion
----------

Don't rely on Request::getPayload() to populate the parsed body

That's just not needed and creates issues like symfony#121

+ fixes a bug with invalid jsons.

Commits
-------

ef03b6d Don't rely on Request::getPayload() to populate the parsed body
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants