minor [Serializer] Fix CS. Uniformize PHPDoc. #12102
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
dunglas
commented
Oct 2, 2014
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| License | MIT |
| /** | ||
| * @param JsonEncode $encodingImpl | ||
| * @param JsonDecode $decodingImpl | ||
| */ |
There was a problem hiding this comment.
This is useless as it does not add any more value than the method signature. Should be removed. Can you do the same where this is the same situation in this PR?
There was a problem hiding this comment.
Done. Should I remove things like the following?
/**
* @var array
*/
protected $normalizers = array();|
Thank you @dunglas. |
fabpot
added a commit
that referenced
this pull request
Oct 3, 2014
This PR was merged into the 2.6-dev branch. Discussion ---------- minor [Serializer] Fix CS. Uniformize PHPDoc. | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT Commits ------- 5be84c4 [Serializer] Fix CS. Uniformize PHPDoc.
| @@ -71,7 +71,8 @@ public function supportsEncoding($format) | |||
| /** | |||
| * Merge default json encode options with context. | |||
| * | |||
| * @param array $context | |||
| * @param array $context | |||
There was a problem hiding this comment.
this change is actually wrong (PHP-CS-Fixer will revert it the next time we run it though)
fabpot
added a commit
that referenced
this pull request
Oct 4, 2014
This PR was merged into the 2.6-dev branch. Discussion ---------- [WIP] minor [Serializer] Fix CS | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT * Reverts CS breaks introduced by #12102 found by @stof and @xabbuh. * Fix CS of `PropertyNormalizer` (missed in last commit) Commits ------- dffa3e4 [Serializer] Fix CS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.