[VarDumper] Improved dump in html #12109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hason
commented
Oct 3, 2014
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | http://www.w3.org/TR/html5/dom.html#the-id-attribute |
| License | MIT |
| Doc PR | - |
| /** | ||
| * Creates unique id for dump. | ||
| */ | ||
| protected function createDumpId() |
There was a problem hiding this comment.
Inline (or private) would be better
| @@ -23,8 +24,9 @@ class HtmlDumper extends CliDumper | |||
| public static $defaultOutputStream = 'php://output'; | |||
|
|
|||
| protected $dumpHeader; | |||
| protected $dumpPrefix = '<pre id=sf-dump>'; | |||
| protected $dumpPrefix = '<pre id=%id%>'; | |||
There was a problem hiding this comment.
please add quotes around the attribute (otherwise you need a more complex escaping)
There was a problem hiding this comment.
Generated id is safe, it contains only [a-z0-9-]
| */ | ||
| public function dump(Data $data, $lineDumper = null) | ||
| { | ||
| $this->dumpId = 'sf-dump-'.md5(mt_rand()); |
There was a problem hiding this comment.
md5 is necessary, mt_rand is enough
1 task
|
👍 |
|
Thank you @hason. |
fabpot
added a commit
that referenced
this pull request
Oct 3, 2014
This PR was merged into the 2.6-dev branch. Discussion ---------- [VarDumper] Improved dump in html | Q | A | ------------- | --- | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | http://www.w3.org/TR/html5/dom.html#the-id-attribute | License | MIT | Doc PR | - Commits ------- f214eda [VarDumper] Added unique id for every single dump in html
fabpot
added a commit
that referenced
this pull request
Oct 5, 2014
This PR was merged into the 2.6-dev branch. Discussion ---------- [VarDumper] Dynamic HTML dumper | Q | A | ------------- | --- | Bug fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12109 | License | MIT | Doc PR | - This PR partially reverts #12109 because it didn't take into account that many dumps can share a single style tag. More importantly, this PR enhance dump rendering with some cute JS navigation effects: - references highlighting on hovering - moving references toggling Here is a screenshot (note the yellow background and the fact that `#2` appears after the first `@2`):  Commits ------- b799844 [VarDumper] Dynamic HTML dumper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.