Skip to content

[WebProfileBundle], [DebugBundle] Fixed big data in toolbar #12113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 3, 2014
Merged

[WebProfileBundle], [DebugBundle] Fixed big data in toolbar #12113

merged 2 commits into from
Oct 3, 2014

Conversation

hason
Copy link
Contributor

@hason hason commented Oct 3, 2014

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Before

prev-01

prev-02

After

post-01

post-02

@nicolas-grekas nicolas-grekas mentioned this pull request Oct 3, 2014
Closed
@nicolas-grekas
Copy link
Member

👍

1 similar comment
@Tobion
Copy link
Contributor

Tobion commented Oct 3, 2014

👍

@fabpot
Copy link
Member

fabpot commented Oct 3, 2014

Thank you @hason.

@fabpot fabpot merged commit febe836 into symfony:master Oct 3, 2014
fabpot added a commit that referenced this pull request Oct 3, 2014
@fabpot
minor #12113 [WebProfileBundle], [DebugBundle] Fixed big data in tool…
9b2195c 
…bar (hason)

This PR was merged into the 2.6-dev branch.

Discussion
----------

[WebProfileBundle], [DebugBundle] Fixed big data in toolbar

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

| Before | After
| --------- | -------
| ![prev-01](https://cloud.githubusercontent.com/assets/288535/4505427/72bd9d08-4af4-11e4-9aed-be4f868c3dfd.png) | ![post-01](https://cloud.githubusercontent.com/assets/288535/4505432/82583746-4af4-11e4-8052-658d4853cfb4.png)
| ![prev-02](https://cloud.githubusercontent.com/assets/288535/4505426/72bd9bb4-4af4-11e4-88ad-1949b6201684.png) | ![post-02](https://cloud.githubusercontent.com/assets/288535/4505431/824fb85a-4af4-11e4-88f5-5e01f907c580.png)

Commits
-------

febe836 [DebugBundle] Removed unnecessary div in toolbar
513d2d3 [WebProfilerBundle] Showed all ajax calls in toolbar
stof
stof reviewed Oct 3, 2014
View reviewed changes
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Profiler/toolbar.css.twig
max-height: 480px;
word-wrap: break-word;
overflow: hidden;
overflow-y: scroll;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

auto would be better than scroll, to add the scrollbar only when necessary instead of adding a scrollbar which cannot scroll.

@hason hason deleted the wdt branch October 3, 2014 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hason @nicolas-grekas @Tobion @fabpot @stof