Skip to content

Removing Controller::getRequest() deprecation note #12121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Removing Controller::getRequest() deprecation note #12121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf7c49e
Removing Controller::getRequest() deprecation note
weaverryan Oct 3, 2014
532ca84
Removing 3.0 UPGRADE note
weaverryan Oct 3, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 0 additions & 35 deletions UPGRADE-3.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,41 +274,6 @@ UPGRADE FROM 2.x to 3.0

### FrameworkBundle

* The `getRequest` method of the base `Controller` class has been deprecated
since Symfony 2.4 and must be therefore removed in 3.0. The only reliable
way to get the `Request` object is to inject it in the action method.

Before:

```
namespace Acme\FooBundle\Controller;

class DemoController
{
public function showAction()
{
$request = $this->getRequest();
// ...
}
}
```

After:

```
namespace Acme\FooBundle\Controller;

use Symfony\Component\HttpFoundation\Request;

class DemoController
{
public function showAction(Request $request)
{
// ...
}
}
```

* The `request` service was removed. You must inject the `request_stack`
service instead.

Expand Down
4 changes: 0 additions & 4 deletions src/Symfony/Bundle/FrameworkBundle/Controller/Controller.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,10 +265,6 @@ public function createFormBuilder($data = null, array $options = array())
* Shortcut to return the request service.
*
* @return Request
*
* @deprecated Deprecated since version 2.4, to be removed in 3.0. Ask
* Symfony to inject the Request object into your controller
* method instead by type hinting it in the method's signature.
*/
public function getRequest()
{
Expand Down