Skip to content

[WIP] minor [Serializer] Fix CS #12127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2014
Merged

Conversation

dunglas
Copy link
Member

@dunglas dunglas commented Oct 4, 2014

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
License MIT

@dunglas dunglas changed the title minor [Serializer] Fix CS [WIP] minor [Serializer] Fix CS Oct 4, 2014
@xabbuh
Copy link
Member

xabbuh commented Oct 4, 2014

👍 I think it's good now. :)

@dunglas
Copy link
Member Author

dunglas commented Oct 4, 2014

I don't understand how these spaces appeared. I've used PHPStorm to generate some docblocks and php-cs-fixer for fixing existing ones and now I cannot reproduce the problem. Strange.

@fabpot fabpot merged commit dffa3e4 into symfony:master Oct 4, 2014
fabpot added a commit that referenced this pull request Oct 4, 2014
This PR was merged into the 2.6-dev branch.

Discussion
----------

[WIP] minor [Serializer] Fix CS

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

* Reverts CS breaks introduced by #12102 found by @stof and @xabbuh.
* Fix CS of `PropertyNormalizer` (missed in last commit)

Commits
-------

dffa3e4 [Serializer] Fix CS
@dunglas dunglas deleted the serializer_cs branch March 6, 2015 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants