[FrameworkBundle] minor fix #12130
Closed
[FrameworkBundle] minor fix #12130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A small fix in the "parse" function of the "ControllerNameParser" Controller. We should use "!==" instead of "!=" since it's better and faster in this case. | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | NA | License | MIT | Doc PR | NA
|
👍 note to maintainers, we should merge this in 2.3 actually (makes merging between branches easier if all CS fixes are applied in all branches) |
|
Thank you @nayzo. |
fabpot
added a commit
that referenced
this pull request
Oct 5, 2014
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #12130). Discussion ---------- [FrameworkBundle] minor fix A small fix in the "parse" function of the "ControllerNameParser" Controller. We should use "!==" instead of "!=" since it's better and faster in this case. | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | NA | License | MIT | Doc PR | NA Commits ------- cd966c6 [FrameworkBundle] minor fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small fix in the "parse" function of the "ControllerNameParser" Controller.
We should use "!==" instead of "!=" since it's better and faster in this case.