Extract an AbstractEventDispatcherTest from EventDispatcherTest #12131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lso use it in ContainerAwareEventDispatcherTest
|
Using |
|
What's the use-case where you want to do this? |
|
This would help projects supplying their own implementations of the |
|
Thank you @znerol. |
fabpot
added a commit
that referenced
this pull request
Nov 20, 2014
…herTest (znerol) This PR was submitted for the master branch but it was merged into the 2.6 branch instead (closes #12131). Discussion ---------- Extract an AbstractEventDispatcherTest from EventDispatcherTest Allow third party implementations of `EventDispatcherInterface` to reuse the `EventDispatcherTest` unit tests. Also instantly expand test coverage of `ContainerAwareEventDispatcher` by rebasing it onto the new `AbstractEventDispatcherTest`. | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 8871368 Extract an AbstractEventDispatcherTest from EventDispatcherTest and also use it in ContainerAwareEventDispatcherTest
|
If |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow third party implementations of
EventDispatcherInterfaceto reuse theEventDispatcherTestunit tests. Also instantly expand test coverage ofContainerAwareEventDispatcherby rebasing it onto the newAbstractEventDispatcherTest.