[TwigBridge] Replace default list style to icon #12164
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What's with the hyphens in the Twig tags? |
|
Thanks @stof! |
|
In case this doesn't get accepted for some reason (or doesn't get accepted for 2.6), I think a good backup plan would be to have this mentioned in the docs. See symfony/symfony-docs#4296. Cheers! |
|
👍 |
1 similar comment
|
👍 |
|
@Macsch15 Can you rebase to remove the merge commit? Thanks. |
|
@fabpot Done :) |
|
Thank you @Macsch15. |
fabpot
added a commit
that referenced
this pull request
Oct 20, 2014
This PR was merged into the 2.6-dev branch. Discussion ---------- [TwigBridge] Replace default list style to icon | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - Replaces default list style in **bootstrap_3_layout.html.twig** to icon. Requires Glyphicons from Bootstrap 3. Before:  After:  Commits ------- 9a0b2cc [TwigBridge] Replace default list style to icon
| {{- parent() -}} | ||
| <ul class="list-unstyled"> | ||
| {%- for error in errors -%} | ||
| <li><span class="glyphicon glyphicon-exclamation-sign"></span> {{ error.message|trans({}, translation_domain) }}</li> |
There was a problem hiding this comment.
the translation is wrong here. error.message is already translated. See the parent template
There was a problem hiding this comment.
@stof I checked it now, after delete trans({}, translation_domain) translations doesn't work.
There was a problem hiding this comment.
what do you mean by "does not work" ? This is how they are displayed in the default theme:
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
Oct 26, 2014
As @stof pointed out in symfony#12164, error messages are already translated when they are passed to the template.
xabbuh
added a commit
to xabbuh/symfony
that referenced
this pull request
Oct 26, 2014
As @stof pointed out in symfony#12164, error messages are already translated when they are passed to the template.
fabpot
added a commit
that referenced
this pull request
Oct 26, 2014
This PR was merged into the 2.6-dev branch. Discussion ---------- don't translate error messages twice | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | As @stof pointed out in #12164, error messages are already translated when they are passed to the template. Commits ------- 4bd8661 don't translate error messages twice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces default list style in bootstrap_3_layout.html.twig to icon.
Requires Glyphicons from Bootstrap 3.
Before:
After:
