[CssSelector] don't raise warnings when exception is thrown #12187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`array_map()` raises a warning when an exception is thrown inside the callback (see https://bugs.php.net/bug.php?id=55416). To avoid these warnings, `selectorToXPath()` is applied inside the loop.
|
I wasn't able to create a proper test for this. Setting an error handler with |
|
@xabbuh yeah, this is what I found when trying to debug it as well. Registering an error handler meant to catch this warning makes it disappear because of the exception, while it is still written in the logs otherwise. |
|
👍 |
|
@stof Yeah, I'm not happy with that since we can't ensure to not have any future regressions. But I don't see how to overcome this. :( |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Oct 9, 2014
…n (xabbuh) This PR was merged into the 2.3 branch. Discussion ---------- [CssSelector] don't raise warnings when exception is thrown | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11947 | License | MIT | Doc PR | `array_map()` raises a warning when an exception is thrown inside the callback (see https://bugs.php.net/bug.php?id=55416). To avoid these warnings, `selectorToXPath()` is applied inside the loop. Commits ------- 38e9623 don't raise warnings when exception is thrown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
array_map()raises a warning when an exception is thrown inside thecallback (see https://bugs.php.net/bug.php?id=55416). To avoid these
warnings,
selectorToXPath()is applied inside the loop.