[VarDumper] enhance dumping refs #12202
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c048c52 to
8738242
Compare
|
Fabbot has only false positives and tests fail because master fails. |
6 tasks
8738242 to
53f0a65
Compare
53f0a65 to
3c401af
Compare
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 17, 2014
This PR was merged into the 2.6-dev branch.
Discussion
----------
[VarDumper] enhance dumping refs
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | nicolas-grekas/Patchwork-Dumper#39
| License | MIT
| Doc PR | -
This makes dumps prettier:
- VarCloner now exposes the "isref" state of a PHP variable
- on hard refs, `#n` suffix is replaced by `&n` prefix
- `#n`/`@n` (object/resource refs) are moved inside the `{ }`
- all repetitive dumps of the same object are toggle-able
- all repetitive dumps of the same object / hard ref are *visually* identical
- dumps expose local ref counts and object's handle
I also simplified the `Cloner\DumperInterface`.
For the same (circumvoluted) variable:
Before:
After:
Commits
-------
3c401af [VarDumper] enhance dumping refs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes dumps prettier:
#nsuffix is replaced by&nprefix#n/@n(object/resource refs) are moved inside the{ }I also simplified the
Cloner\DumperInterface.For the same (circumvoluted) variable:
Before:
After:
