👍 for this PR! :)

Will this be available on 2.6 version?

This looks good to me but I have some questions:

• the error message for the shortcut notation has been removed and so, the behavior is different than before. Basically, we cannot validate the format anymore as it can be several things.
• because the error message is different, do we merge this one in 2.3? If not, it can be in 2.6 but then, this is a problem when trying to apply the best practices in an "older" project.

ping @weaverryan @javiereguiluz

If best practices should be able to apply on >=2.3, so yes, I think this bug fix would be merge on 2.3 and 2.6.

@fabpot I agree that this should be backported to 2.3 because old projects use best practices too.

Hey guys!

I did some digging around, because the flow here is quite complex (there are several layers of try-catch).

Basically, we need to not throw an exception from TemplateNameParser, because it causes the true exception to be "covered up" (e.g. The file "foo/bar2.html.twig" does not exist (in: /path/to/project/app/Resources)). So I like the solution (I tried it out locally).

As far as the behavior changing, it really doesn't. We're no longer throwing an exception from TemplateNameParser. But this only causes the $previous variable here to be the more clear InvalidArgumentException (message listed above) instead of the InvalidArgumentException that was replaced.

So unless you're using the TemplateNameParser directly, there is no behavior change (just a different exception message). If avoided merging this into 2.3, it would be because of that. If that is a problem, we could create a slightly more elaborate patch for 2.3 that would fully protect BC.

Regardless, I think getting this into 2.3 is important - the error message is much much better after this patch.

Cheers!

closed in favor of #12894 ( +2.3 ).