-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[DX] [Form] [WebProfiler] Added abbrs with type classes #12268
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Why |
#12267 seems to be a better fix in my opinion. |
@xabbuh, you've mixed my today's pull requests. #12267 fixes a problem giving a better solution (well, at least IMHO), while this PR adds some verbosity to the component. |
@kix but in the events panel, this can be considered as an abbreviation, as the display text is the short class name, and the title is the FQCN. Here, you are mixing the name of the field and the class name of the form type being used, which are 2 different things |
and giving the name of the form type would be better than its class name IMO anyway |
I'm not sure this is needed. Hovering for 1-2 seconds is much slower than clicking the entry and checking the type on the right, no? |
@kix But you can see from your screenshot that the behavior is inconsistent now. Once you hover over the type name, and then over the form name. Why (from a usability perspective) should hovering over these two different things show the same tooltip? |
7239e64
to
45932f7
Compare
This adds an <abbr> element having a descriptive title that displays the form element's type class name.
45932f7
to
1c78573
Compare
Better! What does the rest of you think? @symfony/deciders |
👍 |
1 similar comment
👍 |
Thank you @kix. |
…(kix) This PR was submitted for the master branch but it was merged into the 2.6 branch instead (closes #12268). Discussion ---------- [DX] [Form] [WebProfiler] Added abbrs with type classes | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | none This adds an `<abbr/>` element having a descriptive title that displays the form element's type class name. Everyone wants to know what's the type behind a form child, yes? Looks like this:  Commits ------- 0d20753 [DX] [Form] [WebProfiler] Added abbrs with type classes
@fabpot 👍! Thanks for merging! |
This adds an
<abbr/>
element having a descriptive title that displays the form element's type class name. Everyone wants to know what's the type behind a form child, yes?Looks like this:
