Various fixes #12285
Merged
Various fixes #12285
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
735c135 to
7e0e2d5
Compare
7e0e2d5 to
e7e734c
Compare
| list($serviceId, $method, $priority) = $args; | ||
| $key = $serviceId.'.'.$method; | ||
| if (isset($this->listeners[$eventName][$key])) { | ||
| if ($listener === array($this->listeners[$eventName][$key], $method)) { |
There was a problem hiding this comment.
you could use && instead of a nested if
e7e734c to
ac8efd9
Compare
|
👍 |
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Oct 26, 2014
This PR was merged into the 2.6-dev branch. Discussion ---------- Various fixes | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12278 | License | MIT | Doc PR | - A 3 in one PR (diff is best viewed [with whitespaces ignored](https://github.com/symfony/symfony/pull/12285/files?w=1)): - changed the way the DebugHandlerListeners desactivates itself - reduced a N×N iteration to a N one in ContainerAwareEventListener::removeListener - fixed an issue in VarDumper Commits ------- ac8efd9 [HttpKernel] fix DebugHandlersListener 5af0f89 [EventDispatcher] perf optim c7cf6cf [VarDumper] fix control chars styling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A 3 in one PR (diff is best viewed with whitespaces ignored):